Skip to content

Commit 4abea34

Browse files
authored
Blocks exynos9820 chip from vulkan (flutter#173807)
fixes flutter#171992 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent eeb3a40 commit 4abea34

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

engine/src/flutter/shell/platform/android/android_context_dynamic_impeller.cc

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,25 @@ namespace {
1717

1818
static const constexpr char* kAndroidHuawei = "android-huawei";
1919

20-
/// These are SoCs that crash when using AHB imports.
21-
static constexpr const char* kBLC[] = {
22-
// Most Exynos Series SoC
20+
static constexpr const char* kBadSocs[] = {
21+
// Most Exynos Series SoC. These are SoCs that crash when using AHB imports.
2322
"exynos7870", //
2423
"exynos7880", //
2524
"exynos7872", //
2625
"exynos7884", //
2726
"exynos7885", //
27+
"exynos7904", //
28+
// Mongoose line.
2829
"exynos8890", //
2930
"exynos8895", //
30-
"exynos7904", //
3131
"exynos9609", //
3232
"exynos9610", //
3333
"exynos9611", //
34-
"exynos9810" //
34+
"exynos9810", //
35+
// `exynos9820` and `exynos9825` have graphical errors:
36+
// https://github.com/flutter/flutter/issues/171992.
37+
"exynos9820", //
38+
"exynos9825" //
3539
};
3640

3741
static bool IsDeviceEmulator(std::string_view product_model) {
@@ -41,7 +45,7 @@ static bool IsDeviceEmulator(std::string_view product_model) {
4145
static bool IsKnownBadSOC(std::string_view hardware) {
4246
// TODO(jonahwilliams): if the list gets too long (> 16), convert
4347
// to a hash map first.
44-
for (const auto& board : kBLC) {
48+
for (const auto& board : kBadSocs) {
4549
if (strcmp(board, hardware.data()) == 0) {
4650
return true;
4751
}
@@ -83,7 +87,8 @@ GetActualRenderingAPIForImpeller(
8387

8488
__system_property_get("ro.product.board", product_model);
8589
if (IsKnownBadSOC(product_model)) {
86-
// Avoid using Vulkan on known bad SoCs.
90+
FML_LOG(INFO)
91+
<< "Known bad Vulkan driver encountered, falling back to OpenGLES.";
8792
return nullptr;
8893
}
8994

0 commit comments

Comments
 (0)