WIP: Update cell density based on cell-avg'ed temperature#135
Open
RonRahaman wants to merge 1 commit intoenrico-dev:masterfrom
Open
WIP: Update cell density based on cell-avg'ed temperature#135RonRahaman wants to merge 1 commit intoenrico-dev:masterfrom
RonRahaman wants to merge 1 commit intoenrico-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the
CoupledDrivercomputes cell density from cell-averaged temperature and the heat/fluid solver's pressure BC using the IAPWS correlation.I'm marking this as "WIP" because, even though it's reasonable for Nek, it might not be appropriate for the heat surrogate. The
SurrogateDriversolves for enthalpy H in fluid; then it computes T from pressure P and H using the IAPWS correlation. Seems odd to compute rho using a second correlation with T and P. Seems like it would be better to directly calculate rho based on T and H. But currently, the base classHeatFluidsdriver doesn't expose H to theCoupledDriver.Given that we eventually want to do enthalpy coupling for all the head/fluids solvers, we might not want to merge this PR. I'm just creating the PR in case @emerzari and @hapfang want to use this for testing.