Skip to content

feat: add ENS forward resolution for referrer parameter #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
storywithoutend wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: add ENS forward resolution for referrer parameter #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4c24c60
feat: add ENS forward resolution for referrer parameter
storywithoutend Nov 20, 2025
21ad2bd
feat: add useResolvedReferrer hook
storywithoutend Nov 20, 2025
1bfc897
feat: integrate ENS forward resolution in ExtendNames flow
storywithoutend Nov 20, 2025
4ea2c6a
feat: integrate ENS forward resolution in registration flow
storywithoutend Nov 20, 2025
392889b
feat: update DesyncedMessage to use resolved referrer
storywithoutend Nov 20, 2025
62b4293
docs: add implementation plan for ENS forward resolution
storywithoutend Nov 20, 2025
0577d0f
Merge branch 'main' into feature/fet-2614-add-reverse-resolving-to-re…
storywithoutend Dec 8, 2025
e544f39
refactor: move referrer dispatch to pricingCallback and add loading s…
storywithoutend Dec 10, 2025
486db07
test: add tests for referrer resolution and clean up variable names
storywithoutend Dec 10, 2025
a4dd528
refactor: move resolution logic into hook and add loading indicators
storywithoutend Dec 10, 2025
c01905a
fix: improve e2e tests for referrer resolution and add ENS name valid…
storywithoutend Dec 12, 2025
dc77522
style: fix import order and trailing newline
storywithoutend Dec 15, 2025
a5c3f91
feat: add referrer error toast notification
storywithoutend Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
991 changes: 991 additions & 0 deletions docs/plans/2025-11-20-add-forward-resolving-to-referrer-parameter.md
View file
Open in desktop

Large diffs are not rendered by default.

150 changes: 140 additions & 10 deletions e2e/specs/stateless/extendNames.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,7 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

const profilePage = makePageObject('ProfilePage')
const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await page.goto(`/${name}?referrer=${referrerAddress}`)
await login.connect()
Expand All @@ -787,12 +788,12 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

// Set extension and proceed
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('1 year')
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Complete transaction
await transactionModal.confirm()

await expect(page.getByText('Your "Extend Names" transaction was successful')).toBeVisible({
await expect(page.getByText('Your "Extend names" transaction was successful')).toBeVisible({
timeout: 10000,
})

Expand All @@ -817,6 +818,7 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

const profilePage = makePageObject('ProfilePage')
const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await page.goto(`/${name}`)
await login.connect()
Expand All @@ -829,7 +831,7 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

// Set extension and proceed
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('1 year')
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Complete transaction
await transactionModal.confirm()
Expand All @@ -856,6 +858,7 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

const profilePage = makePageObject('ProfilePage')
const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await profilePage.goto(name)
await login.connect()
Expand All @@ -871,7 +874,7 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {

// Set extension and proceed
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('1 year')
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Complete transaction
await transactionModal.confirm()
Expand All @@ -885,6 +888,66 @@ test.describe('Legacy/Unwrapped Name Extension with Referrer', () => {
const referrerHex = addressToBytes32(referrerAddress)
expect(latestTransaction.input).toContain(referrerHex.slice(2)) // Remove '0x' prefix for comparison
})

test('should extend unwrapped name with ENS name as referrer', async ({
page,
login,
accounts,
makeName,
makePageObject,
}) => {
// Create an ENS name that will be used as referrer (has an ETH address record)
const referrerName = await makeName({
label: 'legacy-ens-referrer-name',
type: 'legacy',
owner: 'user2',
records: {
coins: [
{
coin: 'ETH',
value: accounts.getAddress('user2'),
},
],
},
})

const name = await makeName({
label: 'legacy-with-ens-referrer',
type: 'legacy',
owner: 'user',
})

const profilePage = makePageObject('ProfilePage')
const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await page.goto(`/${name}?referrer=${referrerName}`)
await login.connect()

// Verify referrer is in URL
expect(page.url()).toContain(`referrer=${referrerName}`)

// Click extend button
await profilePage.getExtendButton.click()

// Set extension and proceed
await page.getByTestId('plus-minus-control-plus').click()
// Wait for referrer to be resolved before clicking
await expect(extendNamesModal.getExtendButton).toBeEnabled({ timeout: 10000 })
await extendNamesModal.getExtendButton.click()

await transactionModal.confirm()

await expect(page.getByText('Your "Extend names" transaction was successful')).toBeVisible({
timeout: 10000,
})

// Verify resolved referrer address in transaction calldata
const latestTransaction = await publicClient.getTransaction({ blockTag: 'latest', index: 0 })
// The ENS name should have resolved to user2's address
const referrerHex = addressToBytes32(accounts.getAddress('user2'))
expect(latestTransaction.input).toContain(referrerHex.slice(2)) // Remove '0x' prefix for comparison
})
})

test.describe('Wrapped Name Renewal with Referrer', () => {
Expand All @@ -903,6 +966,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
})

const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

// Add referrer parameter to URL
const referrerAddress = '0x1234567890123456789012345678901234567890'
Expand All @@ -917,7 +981,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('1 year')

// Proceed to transaction
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Complete transaction
await transactionModal.confirm()
Expand Down Expand Up @@ -947,6 +1011,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
})

const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')
const referrerAddress = '0x1234567890123456789012345678901234567890'

// Start on profile page with referrer
Expand Down Expand Up @@ -982,7 +1047,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('2 years')

// Proceed
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Verify referrer persisted
expect(page.url()).toContain(`referrer=${referrerAddress}`)
Expand All @@ -1009,6 +1074,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
})

const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

// Navigate without referrer parameter
await page.goto(`/${name}`)
Expand All @@ -1018,7 +1084,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {

await expect(page.getByTestId('plus-minus-control-label')).toHaveText('1 year')

await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

await transactionModal.confirm()

Expand All @@ -1028,6 +1094,68 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
})
})

test('should extend wrapped name with ENS name as referrer', async ({
page,
login,
accounts,
makeName,
makePageObject,
}) => {
// Create an ENS name that will be used as referrer (has an ETH address record)
const referrerName = await makeName({
label: 'extend-referrer',
type: 'legacy',
owner: 'user2',
records: {
coins: [
{
coin: 'ETH',
value: accounts.getAddress('user2'),
},
],
},
})

const name = await makeName({
label: 'wrapped-ens-referrer',
type: 'wrapped',
owner: 'user',
duration: daysToSeconds(30),
})

const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await page.goto(`/${name}?referrer=${referrerName}`)
await login.connect()

// Verify referrer is in URL
expect(page.url()).toContain(`referrer=${referrerName}`)

// Click extend button
await page.getByTestId('extend-button').click()

// Set extension and proceed
await page.getByTestId('plus-minus-control-plus').click()
await expect(page.getByTestId('plus-minus-control-label')).toHaveText('2 years')

// Wait for referrer to be resolved before clicking
await expect(extendNamesModal.getExtendButton).toBeEnabled({ timeout: 10000 })
await extendNamesModal.getExtendButton.click()

await transactionModal.confirm()

await expect(page.getByText('Your "Extend names" transaction was successful')).toBeVisible({
timeout: 10000,
})

// Verify resolved referrer address in transaction calldata
const latestTransaction = await publicClient.getTransaction({ blockTag: 'latest', index: 0 })
// The ENS name should have resolved to user2's address
const referrerHex = addressToBytes32(accounts.getAddress('user2'))
expect(latestTransaction.input).toContain(referrerHex.slice(2)) // Remove '0x' prefix for comparison
})

test('should use correct contract for wrapped vs unwrapped names', async ({
page,
login,
Expand All @@ -1050,12 +1178,13 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
})

const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

// Test wrapped name renewal
await page.goto(`/${wrappedName}`)
await login.connect()
await page.getByTestId('extend-button').click()
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Note: In a real test, we would inspect the transaction data to verify
// it's calling the correct contract (UniversalRegistrarRenewalWithReferrer)
Expand All @@ -1068,7 +1197,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
// Test legacy name renewal
await page.goto(`/${legacyName}`)
await page.getByTestId('extend-button').click()
await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Note: This should use the standard ETHRegistrarController
await transactionModal.confirm()
Expand Down Expand Up @@ -1110,6 +1239,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
const address = accounts.getAddress('user')
const addressPage = makePageObject('AddressPage')
const transactionModal = makePageObject('TransactionModal')
const extendNamesModal = makePageObject('ExtendNamesModal')

await page.goto(`/my/names?address=${address}`)
await login.connect()
Expand All @@ -1134,7 +1264,7 @@ test.describe('Wrapped Name Renewal with Referrer', () => {
// Check that we're extending at least 3 names (the ones we created)
await expect(page.getByText(/Extend 3 Names/)).toBeVisible()

await page.locator('button:has-text("Next")').click()
await extendNamesModal.getExtendButton.click()

// Complete transaction
await transactionModal.confirm()
Expand Down
Loading
Loading