Skip to content

Comments

Fix flaky verifications test#1100

Open
storywithoutend wants to merge 12 commits intomainfrom
feature/fet-2731-app-v3-fix-flaky-test-from-race-condition-in-verifications
Open

Fix flaky verifications test#1100
storywithoutend wants to merge 12 commits intomainfrom
feature/fet-2731-app-v3-fix-flaky-test-from-race-condition-in-verifications

Conversation

@storywithoutend
Copy link
Collaborator

The verifications test was flaky because navigating with OAuth params before connecting could show a "not logged in" error dialog that blocks the connect button. Now we connect first, then navigate with OAuth params.

🤖 Generated with Claude Code

The verifications test was flaky because navigating with OAuth params
before connecting could show a "not logged in" error dialog that blocks
the connect button. Now we connect first, then navigate with OAuth params.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 15, 2025

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5270d60
Status: ✅  Deploy successful!
Preview URL: https://fe829a5a.ens-app-v3.pages.dev
Branch Preview URL: https://feature-fet-2731-app-v3-fix.ens-app-v3.pages.dev

View logs

@socket-security
Copy link

socket-security bot commented Jan 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​tenkeylabs/​dappwright@​2.11.2 ⏵ 2.13.181 +510095 +496 +7100
Updated@​playwright/​test@​1.50.1 ⏵ 1.57.010010010099100

View full report

@socket-security
Copy link

socket-security bot commented Jan 6, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants