fix: verify ETH address record matches in usePrimaryName mismatch case#1105
Open
storywithoutend wants to merge 2 commits intomainfrom
Open
fix: verify ETH address record matches in usePrimaryName mismatch case#1105storywithoutend wants to merge 2 commits intomainfrom
storywithoutend wants to merge 2 commits intomainfrom
Conversation
When a name's match property is false (mismatch case), verify that the name's ETH address record actually resolves to the input address before returning the name. This prevents showing a primary name on the address page when the name's ETH address points to a different address than the one being viewed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying ens-app-v3 with
|
| Latest commit: |
7bffced
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eac17c8e.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fix-primary-name-address-mis.ens-app-v3.pages.dev |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a name's match property is false (mismatch case), verify that the name's ETH address record actually resolves to the input address before returning the name. This prevents showing a primary name on the address page when the name's ETH address points to a different address than the one being viewed.