Skip to content

Comments

ENSIP-20 Implementation#226

Open
pikonha wants to merge 21 commits intoensdomains:mainfrom
blockful:main
Open

ENSIP-20 Implementation#226
pikonha wants to merge 21 commits intoensdomains:mainfrom
blockful:main

Conversation

@pikonha
Copy link

@pikonha pikonha commented Mar 26, 2025

  • Add EIP-7884 ABIs
  • Add ENSIP-20 handler
  • Features changed:
    • Create subname
    • Set records
    • Set text
    • Set address
    • Set ABI
    • Set contenthash

Onchain flow:

sequenceDiagram
    Note over Client: calldata = encode(func(...args))
    rect rgb(220, 240, 220)
        Note over Client,L1 Contract: view call
        Client ->> L1 Contract: getOperationHandler(calldata)
        L1 Contract -->> Client: revert OperationHandledOnchain(chainId, contract)
    end
    Client ->> L2 Contract: call(calldata)
Loading

Offchain flow:

sequenceDiagram
  Note over Client: calldata = encode(func(...args))
  rect rgb(220, 240, 220)
      Note over Client,L1 Contract: view call
      Client ->> L1 Contract: getOperationHandler(calldata)
      L1 Contract -->> Client: revert OperationHandledOffchain(sender, url, data)
  end
  Client ->> Client: EIP-712 signature
  rect rgb(220, 220, 240)
      Note over Client,Gateway: HTTP request
      Client->>Gateway: POST url {sender, data, signature}
      Gateway->>Gateway: Verify EIP-712 signature
      Gateway->>Gateway: Process mutation
      Gateway -->> Client: response
  end
Loading

Disclaimer

The implementation still misses some key features that will be added in future PRs:

  • the EIP-7528 implementation for paying fees through an ERC-20 token
  • the commit/reveal for subdomain registering
  • subdomain transferring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant