EnsoMultiValue.firstDispatch to speed benchmarks up#11975
Merged
JaroslavTulach merged 31 commits intodevelopfrom Jan 10, 2025
Merged
EnsoMultiValue.firstDispatch to speed benchmarks up#11975JaroslavTulach merged 31 commits intodevelopfrom
EnsoMultiValue.firstDispatch to speed benchmarks up#11975JaroslavTulach merged 31 commits intodevelopfrom
Conversation
…nsoMultiValue instance
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
Jan 5, 2025
| return newNode.newValue(copyTypes, 1, mv.values); | ||
| } else { | ||
| copyTypes = copyTypes.clone(); | ||
| var copyValues = mv.values.clone(); |
Member
Author
There was a problem hiding this comment.
The idea behind this PR's speed up is to avoid mv.values.clone() when we only need to select new single pivot value. Instead we give each EnsoMultiValue a firstDispatch index into the array that identifies the location of the currently selected type. Then ths reorderOnly operation can share the same mv.values array with the new EnsoMultiValue.
3 tasks
JaroslavTulach
added
the
CI: Keep up to date
… wip/jtulach/FirstDispatch11846
JaroslavTulach
added
CI: Clean build required
Member
Author
|
Benchmarks results. Twice as fast:
Twice as fast: Remains the same: Remains the same: |
Akirathan
approved these changes
Jan 10, 2025
Contributor
Akirathan
left a comment
Akirathan
left a comment
There was a problem hiding this comment.
I like the speedup and the number of asserts in EnsoMultiValue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Even more speed up for benchmarks introduced by #11846. Avoids cloning of array in
reorderOnlysituation at the expense of additionalintfield in eachEnsoMultiValueobject.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,