Skip to content

Workaround NI on MacOS issues with NaN formatting#14572

Merged
hubertp merged 1 commit intodevelopfrom
wip/hubert/14567-nan-macos
Jan 7, 2026
Merged

Workaround NI on MacOS issues with NaN formatting#14572
hubertp merged 1 commit intodevelopfrom
wip/hubert/14567-nan-macos

Conversation

@hubertp
Copy link
Collaborator

@hubertp hubertp commented Jan 6, 2026

Pull Request Description

DecimalFormat suddenly decided to format Double.NaN as U+FFFD REPLACEMENT CHARACTER (or ?) on MacOS in NI mode. There were no changes to the underlying code or configs so it's a bit of a mystery why it started now when it worked before.

Setting explicitly the name in DecimalFormatSymbols does the job, because modifying reflection configs for NI didn't help.

Closes #14567.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

`DecimalFormat` suddenly decided to format Double.NaN
as `U+FFFD REPLACEMENT CHARACTER` (or `?`) on MacOS in NI mode.
There were no changes to the underlying code or configs so it's a bit of
a mystery why it started now when it worked before.

Setting explicitly the name in `DecimalFormatSymbols` does the job,
because modifying reflection configs for NI didn't help.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 6, 2026
@hubertp hubertp merged commit 4eead99 into develop Jan 7, 2026
104 of 108 checks passed
@hubertp hubertp deleted the wip/hubert/14567-nan-macos branch January 7, 2026 09:03
@enso-bot
Copy link

enso-bot bot commented Jan 11, 2026

Hubert Plociniczak reports a new STANDUP for the provided date (2026-01-06):

Progress: Reproducing and fixing NaN issues that started breaking CI on MacOS. Updating visualizations work, picking up where left off before holidays. It should be finished by 2026-01-06.

Next Day: Next day I will be working on the #10525 task. Continue work on visualizations.

jdunkerley pushed a commit that referenced this pull request Jan 13, 2026
`DecimalFormat` suddenly decided to format Double.NaN
as `U+FFFD REPLACEMENT CHARACTER` (or `?`) on MacOS in NI mode.
There were no changes to the underlying code or configs so it's a bit of
a mystery why it started now when it worked before.

Setting explicitly the name in `DecimalFormatSymbols` does the job,
because modifying reflection configs for NI didn't help.

(cherry picked from commit 4eead99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data_Formatter mishandles NaN on MacOS

3 participants