Skip to content

Moving Faker out of Standard.Test API#14701

Open
JaroslavTulach wants to merge 1 commit intodevelopfrom
wip/jtulach/FakerIsOnlyUsedByBenchmarks12456
Open

Moving Faker out of Standard.Test API#14701
JaroslavTulach wants to merge 1 commit intodevelopfrom
wip/jtulach/FakerIsOnlyUsedByBenchmarks12456

Conversation

@JaroslavTulach
Copy link
Member

Pull Request Description

  • another fix for Clean Standard.Test API up #12456
  • Faker is only used in test/Benchmarks
    • hard to imagine such generators as a generic purpose API
  • hence moving the class out of Standard.Test API

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    style guides.
  • Unit tests and benchmarks continue to execute well

@JaroslavTulach JaroslavTulach self-assigned this Jan 28, 2026
@JaroslavTulach JaroslavTulach added the -libs Libraries: New libraries to be implemented label Jan 28, 2026
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed previously I want the Faker API in the standard libraries and part of Standard.Test makes sense to me.

It is useful to be able to create mock data and use it within workflow scenarios

@JaroslavTulach
Copy link
Member Author

As discussed previously I want the Faker API in the standard libraries and part of Standard.Test makes sense to me.

It is useful to be able to create mock data and use it within workflow scenarios

  • so far it has been useful only for benchmarks
  • it is always easier to add new functionality to an API than to remove it
  • can we move the Faker out for now and add it only when somebody really needs it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs Libraries: New libraries to be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants