Avoid SVM Deoptimizer.rewriteStackStub crash#14774
Open
JaroslavTulach wants to merge 6 commits intodevelopfrom
Open
Avoid SVM Deoptimizer.rewriteStackStub crash#14774JaroslavTulach wants to merge 6 commits intodevelopfrom
Deoptimizer.rewriteStackStub crash#14774JaroslavTulach wants to merge 6 commits intodevelopfrom
Conversation
JaroslavTulach
requested review from
4e6,
AdRiley,
PabloBuchu,
farmaazon,
hubertp,
jdunkerley,
kazcw and
vitvakatu
as code owners
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
changed the title
Deoptimizer.rewriteStackStub crashDeoptimizer.rewriteStackStub crash
JaroslavTulach
commented
Feb 19, 2026
| ScheduledExecutorService newScheduledThreadPool(int cnt, String name, boolean systemThread) { | ||
| var s = new ScheduledThreadPoolExecutor(cnt, new Factory(name, systemThread)); | ||
| s.allowCoreThreadTimeOut(true); | ||
| var s = Executors.newScheduledThreadPool(cnt, new Factory(name, systemThread)); |
Member
Author
There was a problem hiding this comment.
@hubertp wrote:
I imagine we could be having deadlocks with this change? Safepoints don't like parked threads...
That's correct! I guess the most important goal right now is to eliminate the Windows crash, but ...
...if we increase guest parallelism...
then using Executors.newScheduledThreadPool is probably not an option as @hubertp points out!
Member
|
Used the newest version all day without an issue on Windows. |
jdunkerley
approved these changes
Feb 20, 2026
JaroslavTulach
added
the
CI: Ready to merge
AdRiley
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ScheduledThreadPoolExecutor..allowCoreThreadTimeOutallows the guest code thread to terminate when idleHypothesis
release/2025.3branch and especially 2025.3.1 is known to be good2025.3.1-nightly.2025.12.1is badProcess of Bisecting
2025.3.1-nightly.2025.12.1and backports f235fff2026.1.1-nightly.2026.1.12026.1.1-nightly.2026.2.12026.1.1-nightly.2026.2.18