Allow selecting tag for execution & display version tags#14883
Merged
mergify[bot] merged 5 commits intodevelopfrom Mar 18, 2026
Merged
Allow selecting tag for execution & display version tags#14883mergify[bot] merged 5 commits intodevelopfrom
mergify[bot] merged 5 commits intodevelopfrom
Conversation
- matching item is removed from any position instead of popping the last item at all times - update both stack and dialogsStack on cleanup
vitvakatu
requested review from
AdRiley,
PabloBuchu,
farmaazon,
jdunkerley and
kazcw
as code owners
kazcw
reviewed
Mar 17, 2026
Comment on lines
+51
to
+54
| const reversedIndex = [...state.stack] | ||
| .reverse() | ||
| .findIndex((item) => item.id === currentId) | ||
| const index = reversedIndex === -1 ? -1 : state.stack.length - reversedIndex - 1 |
Contributor
Author
There was a problem hiding this comment.
Thanks, yeah it would be better.
| type StartDateValue = CalendarDate | CalendarDateTime | ZonedDateTime | ||
|
|
||
| /** Return whether a value looks like an internationalized date object. */ | ||
| function isDateValueLike(value: unknown): value is StartDateValue { |
Contributor
There was a problem hiding this comment.
I don't see what this function is doing that couldn't be done with a z.object schema?
Contributor
Author
There was a problem hiding this comment.
Weird, it turns out z.instanceof(ZonedDateTime).or(z.null()).optional() blows up while z.instanceof(ZonedDateTime).nullable().optional() works perfectly fine. Zod bug? I removed this excessive validation as it is unnecessary. z.object() on its own won't help as it requires ugly type conversion to StartDateValue type anyway, which this function kinda hides thanks to TS typesystem? Anyway, not relevant now.
kazcw
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes https://github.com/enso-org/cloud-v2/issues/2329
Closes https://github.com/enso-org/cloud-v2/issues/2326
CleanShot.2026-03-17.at.17.27.15.mp4
Additional fixes:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.