Add jQuery Popup overlay#206
Merged
enthec-opensource merged 3 commits intoenthec:mainfrom Apr 29, 2025
Merged
Conversation
geoff-rmtech
commented
Apr 28, 2025
| 53 | ||
| ], | ||
| "cpe": "cpe:2.3:a:glpi-project:glpi:*:*:*:*:*:*:*:* ", | ||
| "cpe": "cpe:2.3:a:glpi-project:glpi:*:*:*:*:*:*:*:*", |
Contributor
Author
There was a problem hiding this comment.
Looks like this is a typo, CPEs should not have spaces at the end.
geoff-rmtech
commented
Apr 28, 2025
| "jquery", | ||
| "/jquery(?:-(\\d+\\.\\d+\\.\\d+))[/.-]\\;version:\\1", | ||
| "/(\\d+\\.\\d+\\.\\d+)/jquery[/.-][^u]\\;version:\\1" | ||
| "/(\\d+\\.\\d+\\.\\d+)/jquery(?!\\.popupoverlay\\.js)[/.-][^u]\\;version:\\1" |
Contributor
Author
There was a problem hiding this comment.
This prevents jQuery Popup Overlay from being mistakenly identified as jQuery.
| "jquery", | ||
| "/jquery(?:-(\\d+\\.\\d+\\.\\d+))[/.-]\\;version:\\1", | ||
| "/(\\d+\\.\\d+\\.\\d+)/jquery[/.-][^u]\\;version:\\1" | ||
| "/(\\d+\\.\\d+\\.\\d+)/jquery(?!\\.popupoverlay\\.js)[/.-][^u]\\;version:\\1" |
Member
There was a problem hiding this comment.
I believe the group you added needs to be a non capturing group with ?:
Contributor
Author
There was a problem hiding this comment.
Sorry, I’m not sure I follow. Are you referring to the part I added to the regex — (?!\\.popupoverlay\\.js) — on this line, or to the "jQuery Popup Overlay" object I added at line 1306?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery Popup overlay is getting mis-identified as jQuery.
I'm afraid I don't have 10 sites - but here is one https://wallacelive.wallacecollection.org/eMP/eMuseumPlus.