-
Notifications
You must be signed in to change notification settings - Fork 0
Replaced gcp config with new env, secret & configmap in subscription #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6bee6d2
NX-13810 Added new env, envFrom, secrets & configMaps option for api-…
fank def4762
Merge remote-tracking branch 'origin/main' into feature/NX-13810
fank 56a37db
:art:
fank 0dc41bc
:art:
fank 632b3b7
:art: Replaced CRLF with LF
fank 5394ee4
Replaced gcp config with new env, secret & configmap
fank 111fa26
Removed obsolete value
fank aaca88f
Merge remote-tracking branch 'origin/main' into fk_newsubscription
fank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # EditorConfig is awesome: https://EditorConfig.org | ||
|
|
||
| # top-most EditorConfig file | ||
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
|
|
||
| # YAML files (Helm charts) | ||
| [*.{yml,yaml}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| # Helm template files | ||
| [*.{tpl,tmpl,gotmpl}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| # Markdown files | ||
| [*.md] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| trim_trailing_whitespace = false | ||
|
|
||
| # Helm ignore file | ||
| [.helmignore] | ||
| indent_style = space | ||
| indent_size = 2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Set default behavior to automatically normalize line endings to LF | ||
| * text=auto eol=lf | ||
|
|
||
| # Ensure all text files use LF | ||
| *.yml text eol=lf | ||
| *.yaml text eol=lf | ||
| *.md text eol=lf | ||
| *.txt text eol=lf | ||
| *.sh text eol=lf | ||
| .gitignore text eol=lf | ||
| .gitattributes text eol=lf | ||
| .editorconfig text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| {{- if or .Values.serial.rtf2html .Values.serial.html2rtf -}} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| labels: | ||
| {{- include "rtf2html.labels" . | nindent 4 }} | ||
| name: {{ include "rtf2html.fullname" . }} | ||
| data: | ||
| {{- if .Values.serial.rtf2html }} | ||
| serial-rtf2html: {{ .Values.serial.rtf2html | b64enc | quote }} | ||
| {{- end }} | ||
| {{- if .Values.serial.html2rtf }} | ||
| serial-html2rtf: {{ .Values.serial.html2rtf | b64enc | quote }} | ||
| {{- end }} | ||
| {{- end -}} | ||
| {{- if or .Values.serial.rtf2html .Values.serial.html2rtf -}} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| labels: | ||
| {{- include "rtf2html.labels" . | nindent 4 }} | ||
| name: {{ include "rtf2html.fullname" . }} | ||
| data: | ||
| {{- if .Values.serial.rtf2html }} | ||
| serial-rtf2html: {{ .Values.serial.rtf2html | b64enc | quote }} | ||
| {{- end }} | ||
| {{- if .Values.serial.html2rtf }} | ||
| serial-html2rtf: {{ .Values.serial.html2rtf | b64enc | quote }} | ||
| {{- end }} | ||
| {{- end -}} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "sensa.fullname" . }} | ||
| labels: | ||
| {{ include "sensa.labels" . | indent 4 }} | ||
| data: | ||
| config.json: {{ .Values.config | toJson | quote }} | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "sensa.fullname" . }} | ||
| labels: | ||
| {{ include "sensa.labels" . | indent 4 }} | ||
| data: | ||
| config.json: {{ .Values.config | toJson | quote }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,24 @@ | ||
| {{- if .Values.persistence.enabled -}} | ||
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: {{ include "sensa.fullname" . }} | ||
| annotations: | ||
| {{- with .Values.persistence.annotations }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} | ||
| labels: | ||
| app.kubernetes.io/name: {{ include "sensa.name" . }} | ||
| helm.sh/chart: {{ include "sensa.chart" . }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| spec: | ||
| accessModes: | ||
| - {{ .Values.persistence.accessMode | quote }} | ||
| resources: | ||
| requests: | ||
| storage: {{ .Values.persistence.size | quote }} | ||
| {{- if .Values.persistence.storageClass }} | ||
| storageClassName: {{ .Values.persistence.storageClass | quote }} | ||
| {{- end }} | ||
| {{- end -}} | ||
| {{- if .Values.persistence.enabled -}} | ||
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: {{ include "sensa.fullname" . }} | ||
| annotations: | ||
| {{- with .Values.persistence.annotations }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} | ||
| labels: | ||
| app.kubernetes.io/name: {{ include "sensa.name" . }} | ||
| helm.sh/chart: {{ include "sensa.chart" . }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| spec: | ||
| accessModes: | ||
| - {{ .Values.persistence.accessMode | quote }} | ||
| resources: | ||
| requests: | ||
| storage: {{ .Values.persistence.size | quote }} | ||
| {{- if .Values.persistence.storageClass }} | ||
| storageClassName: {{ .Values.persistence.storageClass | quote }} | ||
| {{- end }} | ||
| {{- end -}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
.editorconfigfile specifiesinsert_final_newline = true, but the file itself is missing a final newline character. To ensure consistency and adhere to the defined rules, a newline should be added at the end of this file.