Add Avery L6026 labels and variable bigger font#35
Open
felsenuboot wants to merge 3 commits intoentropia:mainfrom
Open
Add Avery L6026 labels and variable bigger font#35felsenuboot wants to merge 3 commits intoentropia:mainfrom
felsenuboot wants to merge 3 commits intoentropia:mainfrom
Conversation
margau
requested changes
Jan 26, 2025
|
|
||
| c.setFont("Helvetica", size * mm) | ||
| text_object = c.beginText() | ||
| text_object.setTextOrigin(y, (y - 2 * mm) / 2) |
Collaborator
There was a problem hiding this comment.
I'm wondering if we need to consider the new size here also
| @@ -25,7 +25,7 @@ positional arguments: | |||
|
|
|||
| options: | |||
Collaborator
There was a problem hiding this comment.
This should be also updated with the new arguments
| label.render(render, count) | ||
| label.render(render, count, args.line_break, args.size) | ||
| label.close() | ||
| print(f"Labels written to {args.output_file}") |
Collaborator
There was a problem hiding this comment.
I'm not too happy about the additional printfs. Maybe we should separate this from this MR, and use proper logging/log levels?
Author
There was a problem hiding this comment.
Sure, will try to do that. I am quite new to the world of programming and especially github so forgive my hesitance. Still learning
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The small labels are difficult to read for people with impaired eyesight, therefore I added and test-printed labels for Avery L6026REV. Because those labels are bigger I added two more command inputs for scaling the font size and for having a line break after ASN. In general this makes it easier to read bigger labels.