Chore: Add backend docker build gh workflow#81
Merged
ItamarMalka merged 12 commits intomainfrom Jan 7, 2025
Merged
Conversation
yaronya
reviewed
Jan 6, 2025
|
|
||
| on: | ||
| repository_dispatch: | ||
| types: [backstage_release] |
Collaborator
There was a problem hiding this comment.
Please specify the required inputs and their description (that is version, as it seems)
| - name: Build and Push Image | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: ../../ |
Contributor
Author
There was a problem hiding this comment.
I think this would get us to the dockerfile folder but I couldn't test it so it might be wrong
.github/workflows/publish.yml
Outdated
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} No newline at end of file | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| - name: Trigger Docker Build | ||
| if: success() |
Collaborator
There was a problem hiding this comment.
Isn't this conditional redundant? otherwise we need it also for the 'Publish to npm' step
Contributor
Author
There was a problem hiding this comment.
Yea sounds like it is redundant 👍
7158621
eranelbaz
reviewed
Jan 7, 2025
Comment on lines
+30
to
+31
| yarn tsc:full | ||
| yarn build:all |
Contributor
There was a problem hiding this comment.
env0-backstage-plugin/packages/backend/Dockerfile
Lines 7 to 8 in 1ee3008
By the docker file you can do it only for the BE don't need to full
Your call
ItamarMalka
force-pushed
the
chore-add-backend-docker-build-stage
branch
from
32998de to
3329f6a
Compare
eranelbaz
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
We need a gh action to push the built backend image into our ghcr
Solution
Add a docker build workflow that would run after we finish publishing a new version into npm
QA