Fix: Re-export env0 components with plugin api#85
Merged
Conversation
ItamarMalka
reviewed
Feb 11, 2025
| const startedAt = new Date(deployment.startedAt); | ||
| const finishedAt = new Date(deployment.finishedAt); | ||
|
|
||
| const durationInSeconds = (finishedAt.getTime() - startedAt.getTime()) / 1000; |
Contributor
There was a problem hiding this comment.
This isn't the same 👀
Are we cool with it? it will be showing worse outputs here
Collaborator
Author
There was a problem hiding this comment.
As discussed, it mimics the same behavior as dayjs.asSeconds() so we're good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
The exported React components (
Env0TabComponentandEnv0EnvironmentDetailsCard) were not wrapped with the env0 plugin context, causing an error when attempting to use them.Solution
Wrap and export the components with the plugin context.
Note: There was an issue with bundling the
dayjspackage. Since we only need to calculate duration in seconds, I replaced it with native Node.js functionality instead.QA
Followed our readme and installed the components on a fresh backstage local server ✅