Merged
Conversation
chpl
changed the title
RLRabinowitz
approved these changes
Mar 9, 2026
yarden-fishler-dev
approved these changes
Mar 9, 2026
…github-script The pullreminders/label-when-approved-action was removed from GitHub. Replace it with actions/github-script@v8 using the Octokit API directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| pull_number, | ||
| }); | ||
|
|
||
| const approvals = reviews.data.filter(r => r.state === 'APPROVED'); |
Contributor
There was a problem hiding this comment.
Shouldn't we also check the identity of the approver? or is that done in a different place?
Contributor
Author
There was a problem hiding this comment.
I think it's part of the GH permissions who can and cannot approve.
github-actions
bot
added
the
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
new go version doesn't supported GOOS/GOARCH pair windows/arm
Solution
exclude it