fix: ignore transactions with amount of 0 on import (#827)

Author: morremeyer

pkg/importer/parser/ynab-import/parse.go

@@ -87,8 +87,9 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,
 			t.Transaction.Amount = amount
 		}
 
+		// Ignore transactions that have an amount of 0
 		if t.Transaction.Amount.IsZero() {
-			return csvReadError(reader, errors.New("the amount for a transaction must not be 0"))
+			continue
 		}
 
 		transactions = append(transactions, t)

pkg/importer/parser/ynab-import/parse_test.go

@@ -65,7 +65,6 @@ func TestErrors(t *testing.T) {
 		{"error-decimal-inflow.csv", "error in line 4 of the CSV: inflow could not be parsed to a decimal"},
 		{"error-decimal-outflow.csv", "error in line 2 of the CSV: outflow could not be parsed to a decimal"},
 		{"error-missing-amount.csv", "error in line 3 of the CSV: no amount is set for the transaction"},
-		{"error-amount-zero.csv", "error in line 4 of the CSV: the amount for a transaction must not be 0"},
 		{"error-outflow-and-inflow.csv", "error in line 2 of the CSV: both outflow and inflow are set for the transaction"},
 	}
 

testdata/importer/ynab-import/bank2ynab-ynap.csv

@@ -1,2 +1,3 @@
 Category,Payee,Date,Inflow,Outflow
 ,exampleIssuer,11/06/2023,,82.8
+,Someone Sending 0 money,11/10/2023,,0