resolve #419: use cmake 'EVAL CODE' to forward arguments passed to 'module' cmake function #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for your help on this topic. Looking at CMake availability in various distribution (https://repology.org/project/cmake/versions), it seems ok to require CMake >= 3.18 for newer releases of Modules. Such requirement is met for instance on EL >= 8, Debian >= 11 or Ubuntu >= 22.04. |
benoitdudu
force-pushed
the
cmake_function_forward_arguments
branch
from
86e8e3d to
d894760
Compare
xdelaruelle
force-pushed
the
cmake_function_forward_arguments
branch
from
d894760 to
736e2f6
Compare
…unction Use cmake 'EVAL CODE' to handle any number of arguments. This change mandates use of cmake >= 3.18. The solution comes from the following blog post: https://crascit.com/2019/01/29/forwarding-command-arguments-in-cmake/ Fixes envmodules#419 Signed-off-by: Benoit Dumas <[email protected]>
Signed-off-by: Xavier Delaruelle <[email protected]>
Signed-off-by: Xavier Delaruelle <[email protected]>
xdelaruelle
force-pushed
the
cmake_function_forward_arguments
branch
from
736e2f6 to
02b5f18
Compare
Apply same kind of code in init script than used on autoinit. Signed-off-by: Xavier Delaruelle <[email protected]>
|
Many thanks again for this contribution. I have added commits to also apply this cmake code change to the init script and to the test utility. Everything is ready. I will merge this pull request when the development for next feature release (5.7) will start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made this pull request to resolve issue #419.
The drawback of the solution I found is that it requires cmake 3.18 because it rely on cmake_language(EVAL CODE) (https://cmake.org/cmake/help/latest/command/cmake_language.html).
I tried other things, but I never managed to get the error message when I test:
module(use "")The solution comes from this blog https://crascit.com/2019/01/29/forwarding-command-arguments-in-cmake/
I ran the following commands to check:
make testmake testinstallBest regards,
Benoît