-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add diplomat support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse normalization, and split and structured logger infra
b7b3193 to
840dc83
Compare
…or diplomat routing. Normalize baseUrl with trailing slash
JustWalters
reviewed
Jan 8, 2026
davemun
previously approved these changes
Jan 8, 2026
…use isAxiosError method, clean-up test
Contributor
Author
|
Thanks for the feedback/reviews, @davemun and @JustWalters . I'm gonna close this PR, make a confluence page with these screenshots, and make a new PR linking to that so the PR description is more guarded since this is public. Will tag you both on it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add diplomat v1 and v2 request and response interceptors, response normalization, and split and structured logger infra
Staging E2E Test - Pairing + Invites
Invites: garaje dashboard -> envoy-plugin-ccure -> session-pool-manager -> diplomat-server -> diplomat-client -> ccure instance -> diplomat-client -> diplomat-server -> session-pool-manager -> envoy-plugin-ccure -> diplomat-server -> diplomat-client -> ccure instance -> diplomat-client -> diplomat-server -> envoy-plugin-ccure -> garaje dashboard
0- Initialize Feature Flags to V2 for Deletion

1- Observe Connected V2 Client

2- Delete Connected V2 Client

3- Update Flags to V1 for Setup and Traffic

4- Download:Open V1 Client

5- Update Client Config to Use Diplomat V1

6- Reload Settings and Connect V1 Client

7- Copy Client Secret into Diplomat V1 Config

8- Reopen Client and See it Connected

9- Toggle Enable and Click Save

10- V1 Client Configured

11- V1 Invite Success | Card Number

12.1- V1 Delete Client Operation

12.2- V2 Invite Success | Visitor Info

13- Update Feature Flags to V2 (remove the vals)

14- V2 Go to Integrations Settings

15- Open V2 Client and Pair

16- Close V2 Client, Update Config, Open Client, Connected

17- V2 Invite Success | Card Number

18- V2 Invite Success | Visitor Info
