Skip to content

feat: add optional params to middleware for client id and secret #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cluckienv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add optional params to middleware for client id and secret #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const VERIFIED = Symbol('verified');
* Returns an instance of bodyParser.json,
* which also verifies that the request came from Envoy.
*
* @param {SignatureVerifierOptions} [options]
* @param {SignatureVerifierOptions & {customClientId?: string, customClientSecret?: string}} [options]
* @returns {connectMiddleware}
*/
function middleware(options) {
Expand All @@ -55,10 +55,13 @@ function middleware(options) {
try {
const now = Date.now();
if (now > threshold) {
const hasCustomCredentials = options && options.customClientId && options.customClientSecret;
const {
access_token: rawAccessToken,
expires_in: expiresIn,
} = await EnvoyAPI.login();
} = hasCustomCredentials
? await EnvoyAPI.login(options.customClientId, options.customClientSecret)
: await EnvoyAPI.login();
accessToken = rawAccessToken;
threshold = now + (expiresIn * 1000) - (1000 * 60 * 10);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@envoy/envoy-integrations-sdk",
"version": "1.5.0",
"version": "1.5.1-beta.1",
"description": "",
"main": "index.js",
"scripts": {
Expand Down
Loading