chore: removes envoy installation requirement for running extproc tests #1385
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 77.43% 77.33% -0.11%
==========================================
Files 131 131
Lines 16569 16591 +22
==========================================
Hits 12831 12831
- Misses 3101 3123 +22
Partials 637 637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Note: we cannot run the latest Envoy version on macOS due to https://github.com/tetratelabs/archive-envoy/issues/12. | ||
| # Once it's supported, the following "binary installation" steps below can be just removed and | ||
| # we can simply exec.Cmd with "go tool -modfile=tools/go.mod func-e run" with the envoy version configured via ENVOY_VERSION env var. |
There was a problem hiding this comment.
we no longer need to test on Envoy latest, which made this PR possible
There was a problem hiding this comment.
also i realized that latest installation had been broken since one-two months ago due to the upstream repo change, so it was useless anyways
mathetake
force-pushed
the
lesssetupforcontributors
branch
from
cca8063 to
d2dc383
Compare
| // This always failing backend is configured to have AWS Bedrock schema so that | ||
| // we can test that the extproc can fallback to the different schema. E.g. Primary AWS and then OpenAI. | ||
| alwaysFailingBackend = filterapi.Backend{Name: "always-failing-backend", Schema: awsBedrockSchema} | ||
| alwaysFailingBackend = filterapi.Backend{Name: "always-failing-backend", Schema: openAISchema} |
There was a problem hiding this comment.
This is very hard to explain but this was accidentally working until v1.36 which makes it possible for extproc return the immediate response correctly, so this makes the embedding endpoint test not working: AWS schema doesn't have support for embedding -> try returning immediate response -> previously it was retry-able (due to timeout) vs not retry-able due to extpric immediate response.
In practice, this schema diff retry test case is already covered in the e2e test so no harm
There was a problem hiding this comment.
note: This file is what func-e honors as you can see in the help message by go tool -modfile=tools/go.mod func-e help run
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
force-pushed
the
lesssetupforcontributors
branch
from
28139b3 to
9f39c49
Compare
|
ready for YOLO |
…ts (envoyproxy#1385) **Description** This removes one of the test requirement which is Envoy by leveraging func-e via go tool. Since Envoy v1.36 was released, so this also upgrades the envoy version used in the test to v1.36 --------- Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: ayush <[email protected]>
Description
This removes one of the test requirement which is Envoy by leveraging func-e via go tool. Since Envoy v1.36 was released, so this also upgrades the envoy version used in the test to v1.36