feat: init dynamic modules work #1564
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mathetake
force-pushed
the
dynamicmodulesinit
branch
from
58ae337 to
f6966e9
Compare
mathetake
force-pushed
the
dynamicmodulesinit
branch
from
f6966e9 to
18a2b96
Compare
mathetake
force-pushed
the
dynamicmodulesinit
branch
from
18a2b96 to
150c142
Compare
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
force-pushed
the
dynamicmodulesinit
branch
from
150c142 to
6ae4e4a
Compare
Signed-off-by: Takeshi Yoneda <[email protected]>
| e.SendLocalReply(500, nil, []byte(fmt.Sprintf("invalid router filter pointer: %v", err))) | ||
| return sdk.RequestHeadersStatusStopIteration | ||
| } | ||
| rf := (*routerFilter)(unsafe.Pointer(uintptr(rfPtr))) // nolint:govet |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
To fix this problem:
- Before converting the int64 value from
strconv.ParseIntinto auintptr, check that it's within the representable (non-negative, and <= math.MaxUintptr) range of typeuintptr. - The lower bound should ensure the parsed value isn't negative (
>= 0), since uintptr is unsigned. - The upper bound can use
math.MaxUintptrfrom themathpackage for the maximum allowed uintptr value. - If the check fails, send a local reply error and bail out as with other failure cases.
- Add an import for
"math"if it isn't already present in this snippet.
The edits are limited to the code shown in internal/dynamicmodule/upstream_filter.go, specifically in the block covering lines 64-138 (the RequestHeaders function), as well as potentially adding the required import.
Suggested changeset
1
internal/dynamicmodule/upstream_filter.go
| @@ -10,6 +10,7 @@ | ||
| "fmt" | ||
| "strconv" | ||
| "unsafe" | ||
| "math" | ||
|
|
||
| "github.com/envoyproxy/ai-gateway/internal/apischema/anthropic" | ||
| cohereschema "github.com/envoyproxy/ai-gateway/internal/apischema/cohere" | ||
| @@ -73,6 +74,10 @@ | ||
| e.SendLocalReply(500, nil, []byte(fmt.Sprintf("invalid router filter pointer: %v", err))) | ||
| return sdk.RequestHeadersStatusStopIteration | ||
| } | ||
| if rfPtr < 0 || uint64(rfPtr) > math.MaxUintptr { | ||
| e.SendLocalReply(500, nil, []byte(fmt.Sprintf("router filter pointer out of uintptr range: %v", rfPtr))) | ||
| return sdk.RequestHeadersStatusStopIteration | ||
| } | ||
| rf := (*routerFilter)(unsafe.Pointer(uintptr(rfPtr))) // nolint:govet | ||
| rf.attemptCount++ | ||
| onRetry := rf.attemptCount > 1 |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wip -- aiming to pass all tests in tests/extproc, without control plane impl
Related Issues/PRs (if applicable)
#90