fix: add reasoning content in request and response for gcp anthropic #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yxia216 <[email protected]>
dosubot
bot
added
the
size:L
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 83.26% 83.30% +0.04%
==========================================
Files 137 137
Lines 12059 12138 +79
==========================================
+ Hits 10041 10112 +71
- Misses 1411 1419 +8
Partials 607 607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hustxiayang
changed the title
Signed-off-by: yxia216 <[email protected]>
hustxiayang
force-pushed
the
gcp-anthropic
branch
from
a0e8f9d to
e09547c
Compare
dosubot
bot
added
size:XL
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
yuzisun
reviewed
Dec 5, 2025
| // The signature for a thinking block. | ||
| Signature *string `json:"signature,omitempty"` | ||
| RedactedContent []byte `json:"redactedContent,omitempty"` | ||
| Signature *string `json:"signature,omitempty"` |
yuzisun
reviewed
Dec 5, 2025
| var str string | ||
| if err := json.Unmarshal(data, &str); err == nil { | ||
| // Try to decode as base64 first (this would be []byte encoded as base64) | ||
| if decoded, err := base64.StdEncoding.DecodeString(str); err == nil { |
Contributor
There was a problem hiding this comment.
Why do we need to decode in gateway ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the following issues:
1 Add reasoning content in the request is also missing in the gcp anthropic
2 The reasoning output of gcp anthropic is not parsed out
In this way, reasoning claude models can have an unified interface.
Other issues:
1 The assistant message of gcp anthropic did not cover the case of array. Fixed.