-
Notifications
You must be signed in to change notification settings - Fork 67
ci: Conditionally build debian/ubuntu based on changed paths #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot before we proceed
next thing - we have a gh-action called torun (in envoyproxy/toolshed/gh-actions) - i forget exactly how it works but im thinking it can possibly be used for figuring out the path - and would allow some configurability - also we prefer to keep actions in house where possible |
|
oh the other thing @copilot - use least indent for yaml arrays |
Done - replaced Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
couple more things @copilot
now wrt to the config for what to run ... i would prefer to move this to an adjacent yaml file the toolshed jq action can easily do the conversion from file to json steps var |
Done - 4 space bash indent, removed unnecessary
Done - using least indent for YAML arrays. Commit a0b224e. |
|
ok - looks good - for some reason ci doesnt run on your prs - which in general is a good thing but now i would like to actually test this |
|
@copilot ^^ |
|
@copilot posting here as you seem to hve mised comment on pr ok - looks good - for some reason ci doesnt run on your prs - which in general is a good thing but now i would like to actually test this |
The CI not running on bot PRs is expected GitHub Actions security behavior - workflows don't automatically run for PRs from first-time contributors or bots to prevent unauthorized access to secrets. You can manually trigger the workflow by pushing a commit, using workflow_dispatch if configured, or by having a maintainer with write access approve the workflow run. |
|
hmm that wasnt it @copilot (Line: 38, Col: 7): Unexpected value 'output-path', (Line: 95, Col: 9): A sequence was not expected |
|
@copilot can you see the CI/actions? there are more syntax errors in the yaml |
I don't have access to view the CI/Actions tab, but I found and fixed the syntax error: removed the undefined |
|
@copilot (Line: 58, Col: 9): Unrecognized named-value: 'matrix'. Located at position 122 within expression: (github.repository == 'envoyproxy/envoy-build-tools' || vars.ENVOY_CI_RUN == 'true') && (github.event_name == 'push' || (matrix.target == 'debian' && needs.detect-changes.outputs.debian == 'true') || (matrix.target == 'ubuntu' && needs.detect-changes.outputs.ubuntu == 'true')) |
Removed the |
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
…tion Co-authored-by: phlax <[email protected]>
Co-authored-by: phlax <[email protected]>
18a14fc to
b435692
Compare
1ccdfe0 to
9cf2b37
Compare
Co-authored-by: phlax <[email protected]>
9cf2b37 to
7aaa89e
Compare
Signed-off-by: Ryan Northey <[email protected]>
3cecf1a to
6c5223a
Compare
|
cc @jwendell |
No description provided.