Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 20, 2025

During recent CI additions, explanatory comments were removed from build scripts, and manifest configuration remained embedded in the workflow file instead of being extracted to config like the path detection logic.

Changes

Restored comments in docker/linux/build.sh

  • Added section comments matching debian_build.sh style (Ubuntu config, multi-arch setup, variant logic, default target)

Restructured .github/config.yml schema

# Before: flat structure
debian:
  paths: [...]
ubuntu:
  paths: [...]

# After: distro-centric organization
debian:
  ci:
    paths: [...]
  manifests: [10 manifest configs]
ubuntu:
  ci:
    paths: [...]
  manifests: [5 manifest configs]

Each distro is now a top-level key with nested ci.paths (for path-based detection) and manifests (for OCI specs) sections, making the configuration more intuitive and self-contained.

Updated .github/workflows/build.yml

  • Extract manifests from config using jq: .debian.manifests | map(. + {tag: (.tag | gsub("{sha}"; "..."))}) | {manifests: .}
  • Reduced workflow from 288 to 196 lines
  • Path detection now reads from .debian.ci and .ubuntu.ci
  • Manifest generation reads from .debian.manifests and .ubuntu.manifests

Manifest configs use {sha} placeholder for runtime substitution instead of inline template expansion.

Original prompt

if you look at the last commit you will see some ci addition

in the course of dev i told you to remove your comments but then you just removed all - i actually wanted the comments that were there already

relatedly you will see that we added a yaml config file and then parsed it - i want to do the same for the other yaml that is currently just embedded in the wf - and to do that we need to rethink the schema for .github/config.yml to accomodate both use cases


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@phlax
Copy link
Member

phlax commented Nov 20, 2025

@copilot i think make the schema more like

ubuntu:
  ci:
    paths:
    ...
  manifests:
  ...
debian: etc

Copilot AI changed the title [WIP] Update .github/config.yml schema for multiple YAML support Consolidate CI configuration: extract manifest specs from workflow to config.yml Nov 20, 2025
Copilot AI requested a review from phlax November 20, 2025 18:16
- Changed from builds/manifests sections to distro-based organization
- Each distro (debian/ubuntu) now contains ci.paths and manifests
- Updated workflow filters to use new paths (.debian.ci, .ubuntu.ci, etc)
- Addresses feedback from @phlax

Co-authored-by: phlax <[email protected]>
Copy link
Contributor Author

Copilot AI commented Nov 20, 2025

@copilot i think make the schema more like

...

Restructured the schema as requested. Each distro is now a top-level key with ci.paths and manifests sections. Workflow filters updated to match the new structure. See commit cefa443.

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the copilot/update-config-schema-for-yaml branch from 369135a to cc2f722 Compare November 20, 2025 18:54
@phlax phlax changed the title Consolidate CI configuration: extract manifest specs from workflow to config.yml ci: extract manifest specs from workflow to config.yml Nov 20, 2025
@phlax phlax marked this pull request as ready for review November 20, 2025 18:56
@phlax phlax requested a review from a team as a code owner November 20, 2025 18:57
@phlax phlax changed the title ci: extract manifest specs from workflow to config.yml ci: Extract manifest specs from workflow to config.yml Nov 20, 2025
@phlax phlax enabled auto-merge (squash) November 20, 2025 18:58
@phlax phlax merged commit 25b4356 into main Nov 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants