Skip to content

[WIP] tooling: Add parallel and pkg_filter macros#21604

Closed
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:tooling-macros
Closed

[WIP] tooling: Add parallel and pkg_filter macros#21604
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:tooling-macros

Conversation

@phlax
Copy link
Member

@phlax phlax commented Jun 7, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 7, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #21604 was opened by phlax.

see: more, trace.

@phlax phlax changed the title tooling: Add parallel and pkg_filter macros [WIP] tooling: Add parallel and pkg_filter macros Jun 7, 2022
@phlax phlax marked this pull request as draft June 7, 2022 11:54
@phlax phlax force-pushed the tooling-macros branch 5 times, most recently from 3be4cb4 to 70ccc08 Compare June 7, 2022 13:20
@phlax phlax changed the title [WIP] tooling: Add parallel and pkg_filter macros tooling: Add parallel and pkg_filter macros Jun 7, 2022
@phlax phlax marked this pull request as ready for review June 7, 2022 13:20
@phlax phlax force-pushed the tooling-macros branch 2 times, most recently from 6a766de to 06a1dd5 Compare June 8, 2022 07:47
@phlax
Copy link
Member Author

phlax commented Jun 8, 2022

flagging relevant discussion #21579 (comment)

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the tooling-macros branch from 06a1dd5 to d76dabf Compare June 8, 2022 21:44
@RyanTheOptimist
Copy link
Contributor

/deps lgtm

@RyanTheOptimist
Copy link
Contributor

I think it would be a good idea to get a review from someone more familiar with the context here, if possible?

@phlax
Copy link
Member Author

phlax commented Jun 9, 2022

sure ill assign @htuch ...

@phlax phlax assigned htuch and unassigned RyanTheOptimist Jun 9, 2022
@htuch
Copy link
Member

htuch commented Jun 10, 2022

Let's get @keith to take a look :)

@phlax
Copy link
Member Author

phlax commented Jun 10, 2022

im gonna mark this WIP while we figure out a way forward - the pkg macro is generally useful but if we can fix the aspects another way then the other wont be necessary

@phlax phlax marked this pull request as draft June 10, 2022 05:04
@phlax phlax changed the title tooling: Add parallel and pkg_filter macros [WIP] tooling: Add parallel and pkg_filter macros Jun 10, 2022
@phlax
Copy link
Member Author

phlax commented Jun 14, 2022

closing this for now - using workers with aspects resolves the issuse that this was addressing - i may bring back the pkg macro in the future as need arises

@phlax phlax closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants