tooling: Optimize config_validation#21607
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Jun 17, 2022
Merged
Conversation
phlax
force-pushed
the
tooling-config_validator
branch
from
3303e53 to
4e04ec0
Compare
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
tooling-config_validator
branch
from
4e04ec0 to
f7c83b8
Compare
phlax
force-pushed
the
tooling-config_validator
branch
9 times, most recently
from
13522b9 to
7dc4711
Compare
phlax
commented
Jun 8, 2022
phlax
force-pushed
the
tooling-config_validator
branch
3 times, most recently
from
3588839 to
38f3880
Compare
Member
Author
|
This one gives a huge speed up to both the docs build and the config validation test The bit im not certain about is that i have shifted the code for the validator to envoy.base.utils and im not sure how that will work with the tools image - ill check further on this, and potentially separate this change |
Member
Author
|
cc @mattklein123 ^^ |
phlax
force-pushed
the
tooling-config_validator
branch
from
38f3880 to
db2b1a9
Compare
Member
Author
|
from checking the code, im reasonably confident this doesnt break anything /wait for #21576 |
phlax
changed the title
config_validationconfig_validation
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
tooling-config_validator
branch
from
db2b1a9 to
b9e59fb
Compare
Member
Author
|
it would be great to land this one, it speeds CI up significantly |
keith
approved these changes
Jun 17, 2022
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]