Skip to content

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 28, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #36857 was opened by dependency-envoy[bot].

see: more, trace.

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax changed the title deps: Bump proxy_wasm_cpp_host -> 3212034 deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) Oct 28, 2024
@phlax
Copy link
Member

phlax commented Oct 28, 2024

/retest kafka download

phlax added 2 commits October 28, 2024 10:50
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member

phlax commented Oct 28, 2024

cc @PiotrSikora i have attempted an update to wasmtime 24.0.0 here and included related deps as suggested

im hitting

In file included from external/src/wasmtime/wasmtime.cc:27:
external/proxy_wasm_cpp_host/src/wasmtime/types.h:16:10: fatal error: 'crates/c-api/include/wasm.h' file not found
#include "crates/c-api/include/wasm.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

https://github.com/envoyproxy/envoy/actions/runs/11552408274/job/32151480980#step:12:4035

i tried to include proxy-wasm/proxy-wasm-cpp-host#420 as a patch - but that didnt help

@PiotrSikora
Copy link
Contributor

@keithmattix did you test your Wasmtime update with Envoy? Could you take a look at this failure?

cc @mpwarres

@keithmattix
Copy link
Contributor

Yeah I'll take a look; there may be some references in envoy that need to updated

@keithmattix
Copy link
Contributor

keithmattix commented Oct 28, 2024

Ah I see; Envoy is still using the old wasm-c-api path; I will push a fix

@keithmattix
Copy link
Contributor

This is as far as I could get: #36880

@phlax phlax changed the title deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) [WIP] deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) Oct 29, 2024
@phlax phlax marked this pull request as draft October 29, 2024 10:40
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 28, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Dec 5, 2024
phlax added a commit that referenced this pull request Jan 7, 2025
…`wamr` -> 2.2.0 (#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes #36880 and #36857

---------

Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Co-authored-by: Ryan Northey <[email protected]>
Co-authored-by: Keith Mattix II <[email protected]>
Yueren-Wang pushed a commit to Yueren-Wang/envoy that referenced this pull request Jan 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Co-authored-by: Ryan Northey <[email protected]>
Co-authored-by: Keith Mattix II <[email protected]>
Signed-off-by: Yueren Wang <[email protected]>
@phlax phlax deleted the dependency/bazel/proxy_wasm_cpp_host/3212034 branch July 24, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants