Skip to content

Conversation

DerekTBrown
Copy link

@DerekTBrown DerekTBrown commented Jul 10, 2025

This implements the proposal from proxy-wasm/spec#89.

This change adds new methods to the SSL ConnectionInfo interface to expose certificate extension OID maps, which allow proxy-wasm filters to access certificate extension data.

The new properties are:

  • connection.oid_map_local_certificate (map)
  • connection.oid_map_peer_certificate (map)
  • upstream.oid_map_local_certificate (map)
  • upstream.oid_map_peer_certificate (map)

Each property provides a map of OID strings to their values extracted from certificate extensions.

This change adds new methods to the SSL ConnectionInfo interface to expose
certificate extension OID maps, which allow proxy-wasm filters to access
certificate extension data. This implements the proposal from
proxy-wasm/spec#89.

The new properties are:
- connection.oid_map_local_certificate (map)
- connection.oid_map_peer_certificate (map)
- upstream.oid_map_local_certificate (map)
- upstream.oid_map_peer_certificate (map)

Each property provides a map of OID strings to their values extracted from
certificate extensions.

Signed-off-by: Derek Brown <[email protected]>
Copy link

Hi @DerekTBrown, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #40178 was opened by DerekTBrown.

see: more, trace.

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #40178 was opened by DerekTBrown.

see: more, trace.

Comment on lines 91 to 92
OidsPeerCertificate,
OidsLocalCertificate,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we could probably drop this in favor of the OidMapPeerCertificate/OidMapLocalCertificate implementation, and just iterate over keys when needed.

Copy link

github-actions bot commented Aug 9, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 9, 2025
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant