Skip to content

Conversation

@sumitkmr2
Copy link
Contributor

@sumitkmr2 sumitkmr2 commented Dec 30, 2025

Commit Message: Remove extra spaces from proto comments causing git-push failure.
Additional Description: After pulling latest main, git-push started failing with this error

ERROR: From ./api/envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto
ERROR: ./api/envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto:125: over-enthusiastic spaces
ERROR: From ./api/envoy/service/ext_proc/v3/external_processor.proto
ERROR: ./api/envoy/service/ext_proc/v3/external_processor.proto:230: over-enthusiastic spaces
ERROR: ./api/envoy/service/ext_proc/v3/external_processor.proto:233: over-enthusiastic spaces

I've removed the culprit extra-spaces from the proto. This was possibly caused by merging #38753

Risk Level: None. Only proto comment changes.
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42809 was opened by sumitkmr2.

see: more, trace.

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #42809 was opened by sumitkmr2.

see: more, trace.

@sumitkmr2 sumitkmr2 marked this pull request as ready for review December 30, 2025 11:54
@sumitkmr2
Copy link
Contributor Author

@markdroth FYI.

@markdroth
Copy link
Contributor

/lgtm api

@agrawroh agrawroh merged commit cbb0436 into envoyproxy:main Dec 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants