dynamic_modules: add dynamic modules support for cert validator#43420
Merged
agrawroh merged 4 commits intoenvoyproxy:mainfrom Feb 12, 2026
Merged
dynamic_modules: add dynamic modules support for cert validator#43420agrawroh merged 4 commits intoenvoyproxy:mainfrom
agrawroh merged 4 commits intoenvoyproxy:mainfrom
Conversation
agrawroh
requested review from
RyanTheOptimist,
botengyao,
ggreenway,
mathetake,
mattklein123 and
wbpcode
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-dm-certpckr
branch
5 times, most recently
from
8762f09 to
2bd3d0c
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-dm-certpckr
branch
from
2bd3d0c to
e52b6f6
Compare
mathetake
reviewed
Feb 12, 2026
Member
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
do you think it's possible to allow the access to the dynamic metadata from the verify callback? we are using it internally so i wonder if it's feasible
Member
Author
Should be feasible. I can add that as a follow-up. |
Member
|
yeah sorry i meant filter_state but yeah should be doable |
mathetake
reviewed
Feb 12, 2026
source/extensions/dynamic_modules/sdk/rust/src/cert_validator.rs
Outdated
Show resolved
Hide resolved
mathetake
reviewed
Feb 12, 2026
source/extensions/dynamic_modules/sdk/rust/src/cert_validator.rs
Outdated
Show resolved
Hide resolved
mathetake
reviewed
Feb 12, 2026
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
previously approved these changes
Feb 12, 2026
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing new extensions to validate the certificates using Dynamic Modules.
Commit Message: dynamic_modules: add dynamic modules support for cert validator
Additional Description: Adds support for writing new extensions to validate the certificates using Dynamic Modules.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added