Skip to content

access_log(grpc): pass command parsers to custom tags (fix DNS filter validation)#43457

Merged
yanavlasov merged 9 commits intoenvoyproxy:mainfrom
garimauttam:fix-43396-dns-grpc-custom-tags-validation
Feb 14, 2026
Merged

access_log(grpc): pass command parsers to custom tags (fix DNS filter validation)#43457
yanavlasov merged 9 commits intoenvoyproxy:mainfrom
garimauttam:fix-43396-dns-grpc-custom-tags-validation

Conversation

@garimauttam
Copy link
Contributor

Fixes #43396

What this PR does

When DNS filter access logs use gRPC logger custom_tags with formatter-style values, validation can fail because extension command parsers are not propagated into gRPC custom tag creation.

This PR threads command_parsers through the gRPC access log path so custom tag formatter values can resolve extension-specific commands (including DNS filter commands).

Changes

  • Plumb command_parsers from gRPC access log config factories (http_config/tcp_config) into gRPC access log impls.
  • Update CommonPropertiesConfig to accept command parsers.
  • Pass command parsers to Tracing::CustomTagUtility::createCustomTag(...).
  • Add a regression test in tcp_config_test to verify custom tag formatter values respect injected command parsers.

Why this fixes the issue

The failure came from building formatter-based custom tags without the extension parser set. After this change, custom tag parsing uses the same parser chain provided by the access log call site, so DNS-specific formatter commands are recognized correctly.

Testing

  • bazel test //test/extensions/access_loggers/grpc:tcp_config_test //test/extensions/access_loggers/grpc:http_config_test

Risk

Low. The change is scoped to parser propagation for gRPC custom tag construction and includes targeted regression coverage.

@repokitteh-read-only
Copy link

Hi @garimauttam, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #43457 was opened by garimauttam.

see: more, trace.

Signed-off-by: garima-uttam <garimauttam@ibm.com>
Signed-off-by: garima-uttam <garimauttam@ibm.com>
@garimauttam garimauttam force-pushed the fix-43396-dns-grpc-custom-tags-validation branch from 816f25d to b80167e Compare February 12, 2026 17:31
@garimauttam garimauttam temporarily deployed to external-contributors February 12, 2026 17:32 — with GitHub Actions Inactive
@garimauttam garimauttam temporarily deployed to external-contributors February 12, 2026 18:01 — with GitHub Actions Inactive
Signed-off-by: garima-uttam <garimauttam@ibm.com>
@garimauttam garimauttam temporarily deployed to external-contributors February 12, 2026 18:17 — with GitHub Actions Inactive
@garimauttam garimauttam temporarily deployed to external-contributors February 12, 2026 18:27 — with GitHub Actions Inactive
@garimauttam garimauttam temporarily deployed to external-contributors February 13, 2026 01:49 — with GitHub Actions Inactive
@garimauttam garimauttam temporarily deployed to external-contributors February 13, 2026 10:29 — with GitHub Actions Inactive
@yanavlasov yanavlasov merged commit 479b41e into envoyproxy:main Feb 14, 2026
26 of 27 checks passed
@garimauttam garimauttam deleted the fix-43396-dns-grpc-custom-tags-validation branch February 14, 2026 09:05
@AntonKanug
Copy link
Contributor

@yanavlasov i had #42915 already open with the same changes + the requested integration tests and was waiting on review FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

access_logs: DNS filter access logs using custom tags in gRPC access logs fails validation

3 participants