-
Notifications
You must be signed in to change notification settings - Fork 606
api: support Formatter trace tag #7485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7485 +/- ##
==========================================
- Coverage 72.37% 72.33% -0.04%
==========================================
Files 232 232
Lines 34143 34143
==========================================
- Hits 24711 24698 -13
- Misses 7659 7670 +11
- Partials 1773 1775 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8620c96 to
b37d450
Compare
b37d450 to
39adc99
Compare
| // Formatter adds value using formatter to each span. | ||
| // It's required when the type is "Formatter". | ||
| // +optional | ||
| Formatter *FormatterCustomTag `json:"formatter,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we have 2 level here ?
does the similar field for access log use the same field name of formatter ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there're two reasons why I used FormatterCustomTag here:
- keep same pattern with others type.
- in case there's more options in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name does align with the changes from envoyproxy/envoy#41697
39adc99 to
b39ea8a
Compare
b39ea8a to
b9e2625
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
|
rethinking this one, do we need an explicit API field for now, in |
if there's no type, it's fine.
We can change the underlying layer of literal to this new formatter type, which is supported. |
sure sgtm |
xref: envoyproxy/envoy#41697
this's useful when users want to add value
REQUESTED_SERVER_NAMEto tag.