-
Notifications
You must be signed in to change notification settings - Fork 608
add admission control functionality #7529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adam Buran <[email protected]>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (38.41%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7529 +/- ##
==========================================
- Coverage 72.28% 72.10% -0.18%
==========================================
Files 231 232 +1
Lines 34084 34225 +141
==========================================
+ Hits 24637 24678 +41
- Misses 7673 7760 +87
- Partials 1774 1787 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Buran <[email protected]>
| // Defaults to true if not specified. | ||
| // | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bool field with a default of true is a little counter-intuitive. Would it make sense to flip the flag and call it PassThrough? Or maybe we could drop it for the firt iteration.
|
hey @aburan28 you've also raised #7016 for adding adaptive concurrency control support, these are similar options to throttle clients based on server characteristics ( latency, load), would help if you can outline your use case first, so we can prioritize one or the other, and document the reasons for adding support for it |
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
What type of PR is this?
This adds the admission control filter.
Exposes the the configuration on the backendtrafficpolicy crd
Before raising a PR, please go through this section of the developer guide, https://gateway.envoyproxy.io/contributions/develop/#raising-a-pr
-->
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No