-
Notifications
You must be signed in to change notification settings - Fork 606
Update Helm install command for Envoy Gateway #7637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scraly
wants to merge
1
commit into
envoyproxy:main
Choose a base branch
from
scraly:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this. When navigating to versioned install docs you get an actual version vs v0.0.0-latest, e.g. https://gateway.envoyproxy.io/v1.6/install/install-helm/#install-with-helm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As n user I don't want to install 0.0.0-latest but instead the latest version, 1.6 for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then shouldn't the user navigate to the v1.6 docs pages? Perhaps for the latest version docs we can instead use the latest version (e.g. 1.6) instead but we shouldn't just remove this flag entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm certainly not an expert on UX but just sharing that the current setup will already facilitate what you mention if you navigate to the versioned docs page instead of "latest".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to understand correctly, so for you it's normal to ask the user to install the v0.0.0-latest instead of the latest version?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is by design @scraly
if a user has intentionally navigated from https://gateway.envoyproxy.io to https://gateway.envoyproxy.io/latest/ they are attempting to access unreleased bleeding edge content, there's even a banner on this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying that a user can get the behavior you're seeking by navigating to the versioned docs pages such as https://gateway.envoyproxy.io/v1.6/install/install-helm/#install-with-helm and it doesn't seem irregular that the
/latestversioned docs would use something like v0.0.0-latest.I'm open to a discussion of whether the
/latestdocs pages (e.g. https://gateway.envoyproxy.io/latest/install/install-helm/#install-with-helm) should also default to the most recent version (e.g. currently v1.6) but I think your change here would break the versioned docs pages in future releases so instead of removing should maphelm-versionforlatestto the most recent version.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @envoyproxy/gateway-maintainers should the
/latestdocs pages use v0.0.0-latest or the most recent release (e.g. currently v1.6) for general docs and install steps?As for some examples:
Personally, the karpenter model makes most sense to me and may fix understandable confusion for users like @scraly who logically think latest will map to the most recent release version.
Edit: missed Arko's comment and didn't realize we had the existing banner. That seems reasonable as well and should be sufficient here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with setting it to the latest release, as only for helm install.
But if it is described with the notice, I think we can keep the old style, we could improve it by setting something like preview, git tag instead of v0.0.0-latest.