-
Notifications
You must be signed in to change notification settings - Fork 606
feat(gateway-helm): support loadBalancerIP for LoadBalancer service type #7686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(gateway-helm): support loadBalancerIP for LoadBalancer service type #7686
Conversation
Signed-off-by: Anton <[email protected]>
|
helm get manifest -n envoy-gateway-system eg | grep "kind: Service" -A 50 |
|
test with values: helm get manifest -n envoy-gateway-system eg | grep "kind: Service" -A 50 |
|
Do I need to update the docs and changelog? |
|
Running Can you also include a test case update to https://github.com/envoyproxy/gateway/blob/main/test/helm/gateway-helm/service-customization.in.yaml? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7686 +/- ##
==========================================
- Coverage 72.36% 72.33% -0.03%
==========================================
Files 233 233
Lines 34343 34343
==========================================
- Hits 24851 24843 -8
- Misses 7712 7717 +5
- Partials 1780 1783 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i run command make How debug and e2e tests? |
What type of PR is this?
feat(gateway-helm)
What this PR does / why we need it:
This PR adds support for setting a static
loadBalancerIPwhen the service type is configured asLoadBalancer. Currently, the Helm chart does not allow users to specify a pre-existing IP address for the LoadBalancer service, which can be required in certain environments (e.g., for IP whitelisting, DNS records, or network policies). With this change, users can defineservice.loadBalancerIPin their values file to assign a fixed IP to the Envoy Gateway service.