Update integration tests to use host.testcontainers.internal
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=========================================
Coverage 86.16% 86.16%
Complexity 361 361
=========================================
Files 42 42
Lines 1178 1178
Branches 97 97
=========================================
Hits 1015 1015
Misses 116 116
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation While I was running the integration test, I found out that `host.docker.internal` doesn't work correctly on Linux. (It worked on Mac and Windows.) `host.docker.internal` is used for the container to access the host but the DNS resolution was keeping failing. While I was debugging on it, I also found out that the Testcontainers provides `host.testcontainers.internal` for the same purpose and there's no reason not to use it. https://java.testcontainers.org/features/networking/ Modification - Use `host.testcontainers.internal` instead of `host.docker.internal` Result - The integration tests now run successfully on Linux. Signed-off-by: minwoox <[email protected]>
minwoox
force-pushed
the
host.testcontainers.internal
branch
from
e5f65a5 to
40ddc19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While I was running the integration test, I found out that
host.docker.internaldoesn't work correctly on Linux. (It worked on Mac and Windows.)host.docker.internalis used for the container to access the host but the DNS resolution was keeping failing. While I was debugging on it, I also found out that the Testcontainers provideshost.testcontainers.internalfor the same purpose and there's no reason not to use it. https://java.testcontainers.org/features/networking/Modification
host.testcontainers.internalinstead ofhost.docker.internalResult