feat(redis): allow separate auth for sentinel vs redis #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fefifofums
force-pushed
the
separate-sentinel-redis-client-auth
branch
from
1fd2a22 to
e436ee8
Compare
fix(logging): revert debugging changes Signed-off-by: Will B <[email protected]> Signed-off-by: Will <[email protected]>
fefifofums
force-pushed
the
separate-sentinel-redis-client-auth
branch
from
e436ee8 to
53fb8e7
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@collin-lee @fefifofums any chance we can revive and bring this in? Sentinel is broken for us with ratelimit without the above. |
Contributor
|
@marwanad @fefifofums - we got conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDIS_SENTINEL_AUTHandREDIS_PERSECOND_SENTINEL_AUTHto specify different connection options