feat: add connection timeout configuration for Redis operations #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM @arkodg thoughts? |
Contributor
|
Looks like it's failing on precommit. Possible to run |
arkodg
reviewed
Oct 23, 2025
README.md
Outdated
|
|
||
| Use the following environment variables to configure timeouts: | ||
|
|
||
| 1. `REDIS_TIMEOUT`: sets the timeout for Redis connection and I/O operations. Default: `10s` |
Contributor
There was a problem hiding this comment.
can you point out the defaults from the lib docs or code
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
updated |
Contributor
Author
|
hi @collin-lee , @arkodg please help me review it again |
Signed-off-by: notdu <huudutg@gmail.com>
Contributor
Author
|
@collin-lee It seems like this PR needs approval from reviewer who have write access |
collin-lee
approved these changes
Oct 26, 2025
Contributor
Author
|
hi @collin-lee, This PR still cannot be merged due to two workflows awaiting approval. This workflow requires approval from a maintainer |
Contributor
|
@notdu - merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #978 - Add REDIS_TIMEOUT first; implement the circuit breaker in a separate PR.
Introduces configurable timeouts for Redis connection and I/O operations via environment variables
REDIS_TIMEOUTandREDIS_PERSECOND_TIMEOUT, defaulting to 10 seconds. Updates the Redis client implementation to utilize these timeouts, enhancing resource management during unresponsive Redis instances.Also updates documentation in README.md to reflect these changes.
Test result: