Skip to content

Conversation

@collin-lee
Copy link
Contributor

…urity

and simplified maintenance. Includes CA certificates automatically and provides debug variant for troubleshooting.

…urity

and simplified maintenance. Includes CA certificates automatically and
provides debug variant for troubleshooting.
Copy link

@morepork morepork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Cleaner than copying the certs from the alpine image.

Dockerfile Outdated

FROM alpine:3.22.2@sha256:4b7ce07002c69e8f3d704a9c5d6fd3053be500b7f1c69fc0d80990c2ad8dd412 AS final
RUN apk --no-cache add ca-certificates && apk --no-cache update
FROM gcr.io/distroless/static-debian12
Copy link

@morepork morepork Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about pinning this to a particular SHA to make builds deterministic?

Also, I think it may as well use the nonroot tag, similar to the envoy build:
https://github.com/envoyproxy/envoy/blob/main/distribution/docker/Dockerfile-envoy#L62

@collin-lee
Copy link
Contributor Author

@arkodg

- Pin gcr.io/distroless/static-debian12:nonroot to specific SHA digest
- Ensures deterministic builds and prevents supply chain attacks
- Use nonroot variant for enhanced security (runs as UID 65532)
- Follows same pattern as Envoy proxy for consistency
- Update documentation to reflect security improvements
@psbrar99 psbrar99 self-requested a review October 28, 2025 18:14
@collin-lee collin-lee merged commit 99d8551 into envoyproxy:main Oct 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants