Add support for passing context to React class based components via contextType#2507
Draft
unverbraucht wants to merge 1 commit intoenzymejs:masterfrom
Draft
Add support for passing context to React class based components via contextType#2507unverbraucht wants to merge 1 commit intoenzymejs:masterfrom
unverbraucht wants to merge 1 commit intoenzymejs:masterfrom
Conversation
Add support for passing context to React class based components that request context via setting .contextType, according to patches posted in enzymejs#2189 (comment). Adds changes to ReactSixteenAdapter and simple test case. Co-authored-by: Kevin Read <me@kevin-read.com> Co-authored-by: Pablo Palacios <pablo.palacios@holidaycheck.com>
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
===========================================
- Coverage 96.31% 71.97% -24.35%
===========================================
Files 49 49
Lines 4207 4210 +3
Branches 1130 1132 +2
===========================================
- Hits 4052 3030 -1022
- Misses 155 1180 +1025
Continue to review full report at Codecov.
|
Author
|
Hmm, the new unit tests are failing, but they're working locally here. I'll try to reproduce this with the respective build configurations |
Author
|
My bad. The tests are expected to fail because they use the unpatched react-shallow-renderer :) |
ljharb
requested changes
Mar 30, 2021
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Could we also add a test that changes the provided value, and ensures that the new value also shows up?
| it('works on a Provider', () => { | ||
| const wrapper = shallow(<OuterComponent />); | ||
| const provides = wrapper.find(Provider).dive(); | ||
| const provider = provides.find(InnerComponent).shallow(); |
Member
There was a problem hiding this comment.
Suggested change
| const provider = provides.find(InnerComponent).shallow(); | |
| const provider = provides.find(InnerComponent).dive(); |
any reason this wouldn't work?
This comment was marked as outdated.
This comment was marked as outdated.
ljharb
force-pushed
the
master
branch
3 times, most recently
from
43eb75e to
39e6b1f
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
16cf05f to
658422b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the patches posted in #2189 (comment) by @forivall (thanks!).
Adds changes to ReactSixteenAdapter and simple test case.