Skip to content

chore: remove entity prefix #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dearsimanovich-epam merged 3 commits into from
Feb 13, 2026
Merged

chore: remove entity prefix #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
456523e
chore: remove entity prefix
dearsimanovich-epam Feb 13, 2026
cfe0fd3
Merge branch 'development' into chore/remove-entity-prefix
dearsimanovich-epam Feb 13, 2026
3d4b03c
Merge branch 'development' into chore/remove-entity-prefix
dearsimanovich-epam Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/ai-dial-admin/src/utils/deployments/entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ export const getIdFormat = (name: string) => {
return name.toLowerCase().replace(/\s+/g, '_');
};

export const getEntityId = (container: Container, route: ApplicationRoute, t: (key: string) => string) => {
return getIdFormat(getEntityName(container, route, t));
export const getEntityId = (container: Container) => {
return getIdFormat(getEntityName(container));
};

export const getEntityName = (container: Container, route: ApplicationRoute, t: (key: string) => string) => {
return `${container.displayName} ${getTranslatedEntity(route, t)}`;
export const getEntityName = (container: Container) => {
return `${container.displayName}`;
};

export const getEntityTemplate = (
Expand All @@ -87,8 +87,8 @@ export const getEntityTemplate = (
transport?: CONTAINER_TRANSPORT,
): DialModel | Toolset | DialInterceptor => {
const template: DialModel | Toolset | DialInterceptor = {
name: getEntityId(container, route, t),
displayName: getEntityName(container, route, t),
name: getEntityId(container),
displayName: getEntityName(container),
description: '',
source: { $type: SOURCE_TYPE.CONTAINER, containerId: container.name },
};
Expand Down Expand Up @@ -119,8 +119,8 @@ export const getAssetTemplate = (
transport: CONTAINER_TRANSPORT,
): Partial<AssetToolset> => {
return {
name: getEntityId(container, route, t),
displayName: getEntityName(container, route, t),
name: getEntityId(container),
displayName: getEntityName(container),
endpoint: container.url,
transport: ENTITY_TRANSPORT[transport],
};
Expand Down
8 changes: 4 additions & 4 deletions apps/ai-dial-admin/src/utils/deployments/tests/entity.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,22 +96,22 @@ describe('entity utils', () => {
describe('getEntityId', () => {
test('generates id based on container name and route', () => {
const container = { displayName: 'MyContainer' } as any;
expect(getEntityId(container, ApplicationRoute.ModelServings, t)).toBe('mycontainer_entities.model');
expect(getEntityId(container)).toBe('mycontainer');
});
});

describe('getEntityName', () => {
test('generates name based on container name and route', () => {
const container = { displayName: 'MyContainer' } as any;
expect(getEntityName(container, ApplicationRoute.ModelServings, t)).toBe(`MyContainer ${EntitiesI18nKey.Model}`);
expect(getEntityName(container)).toBe(`MyContainer`);
});
});

describe('getEntityTemplate', () => {
test('returns basic template', () => {
const container = { displayName: 'MyContainer', name: '123' } as any;
const template = getEntityTemplate(ApplicationRoute.InterceptorContainers, container, t);
expect(template.name).toBe('mycontainer_entities.interceptor');
expect(template.name).toBe('mycontainer');
expect(template.source?.containerId).toBe('123');
});

Expand All @@ -134,7 +134,7 @@ describe('entity utils', () => {
test('returns asset template', () => {
const container = { displayName: 'MyContainer', url: 'http://url' } as any;
const template = getAssetTemplate(ApplicationRoute.McpContainers, container, t, CONTAINER_TRANSPORT.SSE);
expect(template.name).toBe('mycontainer_entities.toolset');
expect(template.name).toBe('mycontainer');
expect(template.endpoint).toBe('http://url');
expect(template.transport).toBe(CONTAINER_TRANSPORT.SSE);
});
Expand Down
Loading