Skip to content

fix: search and breadcrumbs size #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PolinaGurinovich97 merged 4 commits into from
Mar 10, 2026
Merged

fix: search and breadcrumbs size #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea46f9
fix: search size
PolinaGurinovich97 Mar 9, 2026
7df317e
fix: breadcrums size
PolinaGurinovich97 Mar 9, 2026
bca04ff
fix test
PolinaGurinovich97 Mar 9, 2026
41d3794
Merge branch 'development' into fix/search
PolinaGurinovich97 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Breadcrumb/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ export const breadcrumbListClassName =
export const breadcrumbItemBaseClassName =
'flex items-center gap-2 min-w-0 shrink-0 dial-small';

export const breadcrumbItemVisibleClassName =
'max-w-[20%] basis-[20%] flex-none';
export const breadcrumbItemVisibleClassName = 'basis-[20%] flex-none';
export const breadcrumbItemLastClassName = 'flex-1 min-w-0';

export const breadcrumbLinkBaseClassName =
Expand Down
2 changes: 1 addition & 1 deletion ...nts/FileManager/components/FileManagerNavigationPanel/FileManagerNavigationPanel.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('Dial UI Kit :: DialFileManagerNavigationPanel', () => {
<DialFileManagerNavigationPanel path="Root" isCompactView searchable />,
);
const searchContainer = screen.getByRole('search');
expect(searchContainer).toHaveClass('w-[38px]');
expect(searchContainer).toHaveClass('w-[40px]');
});

test('search container expands to full width when clicked in compact view', () => {
Expand Down
9 changes: 5 additions & 4 deletions ...mponents/FileManager/components/FileManagerNavigationPanel/FileManagerNavigationPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export const DialFileManagerNavigationPanel: FC<
{searchable && (
<div
className={mergeClasses(searchContainerWrapperClassName, {
'w-[38px]': isCompactView && !isSearchExpanded,
'w-[40px]': isCompactView && !isSearchExpanded,
'w-full': isCompactView && isSearchExpanded,
})}
role="search"
Expand All @@ -296,9 +296,10 @@ export const DialFileManagerNavigationPanel: FC<
onBlur={handleSearchBlur}
invalid={invalid}
className={searchClassName}
containerClassName={mergeClasses(searchContainerClassName, {
'p-[10px]': isCompactView,
})}
wrapperClassName={
isCompactView && !isSearchExpanded ? 'pl-2.5' : ''
}
containerClassName={searchContainerClassName}
/>
</div>
)}
Expand Down