Skip to content

Conversation

@zmotso
Copy link
Member

@zmotso zmotso commented Nov 4, 2025

Pull Request Template

Description

Add CloneRepositoryCredentials field to Codebase spec to support configurable repository credentials management. This replaces the hardcoded secret name pattern with a flexible reference-based approach.

The new field includes:

  • secretRef: reference to credential secret
  • clearSecretAfterUse: flag to control secret cleanup behavior

This change maintains backward compatibility by falling back to the legacy secret naming pattern when CloneRepositoryCredentials is not specified. The implementation includes comprehensive test coverage for various credential scenarios, including missing secrets, empty credentials, and secret retention policies.

Fixes #234

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

  • Unit tests
  • Manually

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

Add CloneRepositoryCredentials field to Codebase spec to support
configurable repository credentials management. This replaces the
hardcoded secret name pattern with a flexible reference-based approach.

The new field includes:
- secretRef: reference to credential secret
- clearSecretAfterUse: flag to control secret cleanup behavior

This change maintains backward compatibility by falling back to the
legacy secret naming pattern when CloneRepositoryCredentials is not
specified. The implementation includes comprehensive test coverage
for various credential scenarios including missing secrets, empty
credentials, and secret retention policies.
@zmotso zmotso self-assigned this Nov 4, 2025
@zmotso zmotso requested a review from a team as a code owner November 4, 2025 11:03
@zmotso zmotso added the enhancement New feature or request label Nov 4, 2025
@MykolaMarusenko MykolaMarusenko merged commit 643fe5b into master Nov 4, 2025
3 checks passed
@MykolaMarusenko MykolaMarusenko deleted the f/234 branch November 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support static secret name reference for private repository clone strategy

3 participants