feat: add GPT-5 model family support #92#140
Conversation
|
/deploy-review
|
|
phrase "partially fixes #" will likely close original issue. maybe rephrase? |
|
/deploy-review
|
|
/deploy-review
|
|
there is a bug in
llm_model: Mapped[str] = mapped_column(default=langchain_settings.default_model.value)I suggest we use: llm_model: Mapped[str] = mapped_column(default=langchain_settings.embedding_default_model.value)and delete default value in class EmbeddingsModelConfig(BaseModelConfig):
"""Config for embeddings models."""
deployment: EmbeddingModelsEnum = Field(
description="The deployment of the model in DIAL"
)@Fedir-Yatsenko what do you think? |
|
/deploy-review
|
shall we move to separate PR, I would also like to change misleading name "llm_model" and we would have to migrate db after. @navalnica |
Let's first create an issue and then discuss it. If you want to change this, let's remove this column. Essentially, this parameter should be part of the Data Query config, not the channel. |
let's change the varname in another PR |
|
/deploy-review
|
|
created follow-up issue to refactor langchain configs #150 |
Applicable issues
Description of changes
Adds GPT-5 model family support with conditional parameter handling:
GPT_5_MINI,GPT_5_1,GPT_5_2ReasoningEffortEnum,VerbosityEnumLLMModelConfigPydantic validator enforces model-family constraints:seed, requiresreasoning_effort, validatestemperature=1when reasoning is enabledreasoning_effortandverbosityget_chat_model()- moved params validation intoLLMModelConfig**kwargsfromget_chat_model()andget_embeddings_model()reasoning_effortandverbositydefaults out ofLangChainSettingsintoLLMModelConfigllm_model: Mapped[str] = mapped_column( default=langchain_settings.embedding_default_model.value )Checklist
Reviewenvironment.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.