feat: Add translation logic from UUID to Source ID and back in Indicator Selection Chain #172#173
Open
veryniceuser wants to merge 5 commits intodevelopmentfrom
Conversation
Open
2 tasks
veryniceuser
changed the title
navalnica
reviewed
Feb 27, 2026
| dataset_alias_to_name: dict[str, str], | ||
| dataset_id_to_source_id: dict[str, str] | None = None, | ||
| ): | ||
| self.dataset_alias_to_name = dataset_alias_to_name |
Contributor
There was a problem hiding this comment.
let's avoid using "alias" term - to avoid confusion with dimension_alias dataset config field
navalnica
reviewed
Feb 27, 2026
| pass | ||
|
|
||
| @abstractmethod | ||
| def translate_dataset_ids(self, source_id_to_dataset_id: dict[str, str]) -> None: |
Contributor
There was a problem hiding this comment.
let's use translate_forward and translate_backward for clarity
Contributor
|
let's get back to this PR after we move to gpt-5* models - to simplify transition to gpt-5* (avoid unnecessary evals). we'll need to run following evals and compare:
to think: on full set of tests / subset, for one/multiple clients, with/without repro |
navalnica
requested changes
Feb 27, 2026
For cleaner separation of concerns
…ate_dataset_uuids_for_indicator_selection_prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Checklist
Reviewenvironment.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.