Skip to content

replace older time functions with more portable ones #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

replace older time functions with more portable ones #570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c862e3
replace older time functions with more portable ones
Gargaj May 17, 2024
154dac3
use __STDC_WANT_LIB_EXT1__ to distinguish use cases
Gargaj May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion implot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ ImPlotTime MkGmtTime(struct tm *ptm) {
#ifdef _WIN32
t.S = _mkgmtime(ptm);
#else
t.S = timegm(ptm);
t.S = mktime(ptm);
#endif
if (t.S < 0)
t.S = 0;
Expand All @@ -923,6 +923,8 @@ tm* GetGmtTime(const ImPlotTime& t, tm* ptm)
return ptm;
else
return nullptr;
#elif defined(__STDC_WANT_LIB_EXT1__)
return gmtime_s(&t.S, ptm);
#else
return gmtime_r(&t.S, ptm);
#endif
Expand All @@ -942,6 +944,8 @@ tm* GetLocTime(const ImPlotTime& t, tm* ptm) {
return ptm;
else
return nullptr;
#elif defined(__STDC_WANT_LIB_EXT1__)
return localtime_s(&t.S, ptm);
#else
return localtime_r(&t.S, ptm);
#endif
Expand Down