Resolve breaking changes in ImGui. #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built implot_demos against ImGui 1.91.5 and had two errors caused by breaking changes in ImGui. They are as follows: ImGui 1.91.4: The typedef for ImTextureID now defaults to ImU64 instead of void*. (#1641) ImGui 1.90.5: More formally obsoleted GetKeyIndex() Reminder: IsKeyPressed(GetKeyIndex(ImGuiKey_XXX)) --> IsKeyPressed(ImGuiKey_XXX)
Author
|
This is my first attempt at a pull request. Hope I did it correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built implot_demos against ImGui 1.91.5 and had two errors caused by breaking changes in ImGui. They are as follows: ImGui 1.91.4: The typedef for ImTextureID now defaults to ImU64 instead of void*. (#1641) ImGui 1.90.5: More formally obsoleted GetKeyIndex() Reminder: IsKeyPressed(GetKeyIndex(ImGuiKey_XXX)) --> IsKeyPressed(ImGuiKey_XXX)