Distilling whisper message and envelope code into message.go #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortatu
added
help wanted
aperonam
reviewed
Sep 5, 2019
aperonam
reviewed
Sep 5, 2019
Distilled whisper message structure and encryption to default crypto implementation. Added Topic to PssMsg Simplified PssMsg Payload to []byte
aperonam
reviewed
Sep 6, 2019
aperonam
approved these changes
Sep 6, 2019
Doc added for Crypto
Removed unused method in crypto.go
…ivate keys in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
message.gofile contained references to whisper message and envelope code. All that whisper code has been copied and distilled into swarm/pss/crypto as the default crypto implementation.Crypto interface now is composed of 3 interfaces.
Sealing the message (poW and Nonce) has been completely removed.
We keep the whisper structure of encrypted message with the format:
flags+payloadSize+payload+padding+signaturebut only inside the default crypto implementation. Now the payload of the whisper message is a simple
[]byte.Topic has been moved from PssMsg.Payload to PssMsg.